Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disable logging in integration environment #753

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

PritishBudhiraja
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Logs were getting triggered for integ env

How did you test it?

Via local testing

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

Copy link

semanticdiff-com bot commented Oct 25, 2024

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Overall, the semantic diff is 72% smaller than the GitHub diff.

Filename Status
✔️ package.json 78.41% smaller
✔️ webpack.common.js Analyzed

@PritishBudhiraja PritishBudhiraja self-assigned this Oct 25, 2024
@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Oct 25, 2024
Copy link
Collaborator

@seekshiva seekshiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DefinePlugin wouldn't work well without the JSON.stringify

@seekshiva seekshiva merged commit 6059f13 into main Oct 28, 2024
4 checks passed
@seekshiva seekshiva deleted the logs-stop-integ branch October 28, 2024 07:40
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants